[Sign] Dapp extend session exp #1187
Conversation
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
|
@flypaper0 extracting the update/extend method to the one service is a bit tricky, cuz NonController also observes the changes made to the session from the wallet side. I'll think about how to refactor this later, cuz it's P1. |
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
| if session.selfIsController { | ||
| try await controllerSessionStateMachine.extend(topic: topic, by: ttl) | ||
| } else { | ||
| try await nonControllerSessionStateMachine.extend(topic: topic, by: ttl) |
There was a problem hiding this comment.
wouldn't be easier to just extract generic "sessionExtendRequester" and have an extend logic in one place?
are the implementations for a dapp and a wallet any different?
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
|
@llbartekll please check again |
There was a problem hiding this comment.
Could we also maybe now extract the on extend part?
now the logic is shared and we still keep request handling and responding in controller and non-controller services.
in let's say SessionExtendRequestSubscriber - that will handle the request and respond
and if needed SessionExtendResponseSubscriber that will handle the response.
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence