[WalletApp] Handle removed session request #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
changed the title
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
flypaper0
reviewed
Nov 14, 2023
| @@ -281,3 +281,12 @@ private extension SessionEngine { | |||
| onEventReceived?(topic, event.publicRepresentation(), payload.request.chainId) | |||
| } | |||
| } | |||
|
|
|||
| extension SessionEngine.Errors: LocalizedError { | |||
| var errorDescription: String? { | |||
There was a problem hiding this comment.
is it better to use WalletConnectError? we have noSessionMatchingTopic for example
There was a problem hiding this comment.
Dunno whether it's better, the SessionEngine has its own Errors. Should I remove this error from SessionEngine then?
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
flypaper0
approved these changes
Nov 16, 2023
| extension SessionEngine.Errors: LocalizedError { | ||
| var errorDescription: String? { | ||
| switch self { | ||
| case .sessionRequestExpired: return "Session request expired" |
There was a problem hiding this comment.
It also can be moved in WalletConnectError imo
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://walletconnect.slack.com/archives/C03S6NN8NHF/p1699699835241069
Due Dilligence