[Notify] Optional icon url #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
reviewed
Nov 20, 2023
|
|
||
| return try content.updating(from: incomingMessagingIntent) | ||
| } | ||
| catch { |
There was a problem hiding this comment.
This feels like a hack to wrap the whole thing in a try/catch. Can't you check for "" and then disable the logic?
There was a problem hiding this comment.
Execution also can failed on:
- downloading resource (network problem) - line 69
- accessing device storage - line 70,71
Before that fix all of that cases failing message decoding
There was a problem hiding this comment.
Nice that we found that
llbartekll
approved these changes
Nov 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence