Fix import issue with WalletConnectUtils #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following compilation error occurs when installed via cocoapods with
DEBUG enabled.
```
37 | )
38 | let signature = CacaoSignature(
> 39 | t: WalletConnectUtils.CacaoSignatureType.eip191,
| ^ cannot find 'WalletConnectUtils' in scope
40 | s: "invalid_signature",
41 | m: nil
42 | )
```
|
|
Faced this issue, too. |
llbartekll
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for considering this change, and please let me know if there's any additional context I can provide. I have not tested this using SPM, and wonder if there may be some conflicts with that installation method. Perhaps we can wrap this in some additional flags to make it only available for SPM, if that's the case?
It's worth noting this issue is blocking installation of the more recent versions of this library via cocoapods.
Description
The following compilation error occurs when installed via cocoapods with DEBUG enabled.
Related: #1340
How Has This Been Tested?
Run a local install + build.
Due Dilligence