Remove pending requests on session expiration #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackpooleywc
force-pushed
the
jack/clear-requests-on-session-expiration
branch
from
b4cd76e
to
f2157fa
Compare
llbartekll
reviewed
May 16, 2024
llbartekll
approved these changes
May 16, 2024
jackpooleywc
force-pushed
the
jack/clear-requests-on-session-expiration
branch
from
f2157fa
to
787c8a9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to #1353.
In addition to clearing stale requests on initialisation, this PR also makes sure requests related to the session are also cleared when the session expires.
Resolves #1343
How Has This Been Tested?
Note
This has not yet been tested against the bug as I am still unable to reproduce, this will be tested before merging.
Due Dilligence