#168 completion errors on public methods #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
llbartekll
commented
May 4, 2022
•
llbartekll
commented
- Rename WalletConnectRelay to NetworkInteractor
- distinguish 3 request methods in NetworkInteractor: request, requestNetworkAck, requestPeerResponse
- Add Concurrency to NetworkInteractor's request and Relayer's publish methods
- Add Concurrency to public disconnect and session request methods
- Apply async disconnect method to sample apps
- Turn off queueing for socket frames - need to add policy here later
-request -requestNetworkAck -requestPeerResponse
fix example apps after client interface changes
sekimondre
approved these changes
May 4, 2022
Comment on lines
+24
to
+32
| // func testTextFramesSentAfterReconnectingSocket() { | ||
| // try! sut.disconnect(closeCode: .normalClosure) | ||
| // sut.send("1"){_ in} | ||
| // sut.send("2"){_ in} | ||
| // XCTAssertEqual(webSocketSession.sendCallCount, 0) | ||
| // try! sut.connect() | ||
| // socketConnectionObserver.onConnect?() | ||
| // XCTAssertEqual(webSocketSession.sendCallCount, 2) | ||
| // } |
There was a problem hiding this comment.
Is this commented test still needed or can it be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.