#201 required chainid #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
approved these changes
May 10, 2022
Comment on lines
128
to
147
| // func testSessionRequestEmptyNamespaceUnmatchingMethod() { | ||
| // var didTriggerRequest = false | ||
| // engine.onSessionRequest = { _ in didTriggerRequest = true } | ||
| // | ||
| // let session = WCSession.stub(isSelfController: true) | ||
| // storageMock.setSession(session) | ||
| // | ||
| // let payload = WCRequestSubscriptionPayload.stubRequest(topic: session.topic, method: "someMethod", chainId: nil) | ||
| // networkingInteractor.wcRequestPublisherSubject.send(payload) | ||
| // | ||
| // XCTAssertTrue(networkingInteractor.didRespondError) | ||
| // XCTAssertFalse(didTriggerRequest) | ||
| // } | ||
| // | ||
| // func testSessionRequestEmptyNamespaceMatchingMethod() { | ||
| // var didTriggerRequest = false | ||
| // engine.onSessionRequest = { _ in didTriggerRequest = true } | ||
| // | ||
| // var session = WCSession.stub(isSelfController: true) | ||
| // session.updateNamespaces([Namespace(chains: [], methods: ["someMethod"], events: [])]) |
There was a problem hiding this comment.
wouldn't it better to just remove it? will stay in git history for reference.
sekimondre
force-pushed
the
#201-required-chainid
branch
from
a74afba
to
d792138
Compare
llbartekll
approved these changes
May 11, 2022
| @@ -6,6 +6,7 @@ enum WalletConnectError: Error { | |||
| case noSessionMatchingTopic(String) | |||
| case sessionNotAcknowledged(String) | |||
| case pairingNotSettled(String) | |||
| case namespaceHasEmptyChains | |||
There was a problem hiding this comment.
personally I would prefer smth like: emptyChainsInNamespaceForbidden or invalidNamespaceStructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #201
Makes
chainIda required parameter in request and event payloads.