Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message signing #23

Merged
merged 6 commits into from
Jan 17, 2022
Merged

Message signing #23

merged 6 commits into from
Jan 17, 2022

Conversation

llbartekll
Copy link
Contributor

  • add personal_sign, eth_signTypedData, eth_sendTransaction signing for example app
  • fix networking issue
  • add description on request screen

@hewigovens
Copy link
Contributor

eth_signTypedData seems not implemented correctly, we're using trust wallet core to sign typed data, if you don't mind to use it in example app

@llbartekll
Copy link
Contributor Author

eth_signTypedData seems not implemented correctly, we're using trust wallet core to sign typed data, if you don't mind to use it in example app

We don't mind, I would appreciate your PR or code snippet how you do it in Trust Wallet.

@llbartekll llbartekll merged commit b02dd1e into develop Jan 17, 2022
@trwggs
Copy link

trwggs commented Mar 13, 2022

eth_signTypedData seems not implemented correctly, we're using trust wallet core to sign typed data, if you don't mind to use it in example app

We don't mind, I would appreciate your PR or code snippet how you do it in Trust Wallet.

@hewigovens do you have a snippet for the correct implementation

@hewigovens
Copy link
Contributor

@trwggs Please take a look at these references

  1. Encode typed message to hash https://github.com/trustwallet/wallet-core/blob/master/swift/Tests/Blockchains/EthereumAbiTests.swift#L213
  2. Sign this hash https://github.com/trustwallet/trust-web3-provider/blob/master/ios/TrustWeb3Provider/DAppWebViewController.swift#L327

@trwggs
Copy link

trwggs commented Mar 14, 2022

@hewigovens thanks that worked. The encodeTyped method is very helpful

@llbartekll llbartekll deleted the message-signing branch March 18, 2022 09:53
@chadyj chadyj mentioned this pull request Aug 8, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants