Cleanup Service + SequenceStore refactor #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the PR should not be to the main branch as we have 2 week release cadence when we are merging develop into main |
llbartekll
requested changes
May 27, 2022
Comment on lines
57
to
59
| func deleteAll() { | ||
| for key in storage.dictionaryRepresentation().keys { | ||
| storage.removeObject(forKey: key) | ||
| } | ||
| } |
There was a problem hiding this comment.
correct me if I am wrong but would it clean all UserDefaults? including consuming app all preferences?
There was a problem hiding this comment.
if so, pretty malicious xD
There was a problem hiding this comment.
Added logic what delete values for current identifier only.
Also improved filtration by identifier. Now it works for "test" and "test2" identifiers too, because they starts with "test"
flypaper0
force-pushed
the
cleanup-service
branch
from
c6a5bc9
to
c163880
Compare
llbartekll
approved these changes
May 30, 2022
sekimondre
reviewed
May 30, 2022
Comment on lines
4
to
21
| final class CleanupService { | ||
|
|
||
| private let pairingStore: WCPairingStorage | ||
| private let sessionStore: WCSessionStorage | ||
| private let kms: KeyManagementServiceProtocol | ||
|
|
||
| init(pairingStore: WCPairingStorage, sessionStore: WCSessionStorage, kms: KeyManagementServiceProtocol) { | ||
| self.pairingStore = pairingStore | ||
| self.sessionStore = sessionStore | ||
| self.kms = kms | ||
| } | ||
|
|
||
| func cleanup() throws { | ||
| pairingStore.deleteAll() | ||
| sessionStore.deleteAll() | ||
| try kms.deleteAll() | ||
| } | ||
| } |
There was a problem hiding this comment.
There are other KeyValueStore in the session and pairing engine used for proposal-approval (even though they are more like workarounds). I think it would be good to clean those too.
There was a problem hiding this comment.
Good catch, need to clean sessionToPairingTopic
sekimondre
approved these changes
May 30, 2022
llbartekll
approved these changes
May 31, 2022
Merged
flypaper0
added a commit
that referenced
this pull request
Jun 9, 2022
* Cleanup Service + SequenceStore refactor (#241) * Cleanup service * Clean sessionToPairingTopic * SequenceStore refactor * Rename KeyValueStore -> CodableStore * Deliver an invite (#254) * Add Chat target, split packages * savepoint * Update networking interactor to decode unencrypted messages * pass on invite test * restructure chat's project folder * Add engine storages * extract storage domain identifiers * update logging * fix schemas * Update style * Add publishers to Chat * rename kv store to codable strore * UI tests (#242) * Pairing testcase * Ping testcase * ApproveSessionExistingPairing test case * Unused extensions deleted * Renamed to RegressionTests * UITests step on CI * CleanLaunch instead of deleting app * Fix test on Real device * Launch App fix * Approve engine refactor (#260) * Approve method moved ApproveEngine * Reject and wcSessionSubscriptions for ApproveEngine * Private methods moved in extension * ApproveEngine errors handlers * Try on reject * ApproveEngine moved to callbacks * Session Settle moved to approve Engine * onProposeResponse subscription removed * Reject by proposalId * Settle moved to approve * ApproveEngine moved to Controller folder * typealias removed * TODO for SettleEngine * #256 JSON-RPC Package (& Commons) (#261) * Add Chat target, split packages * savepoint * restructure chat's project folder * fix schemas * Add JSONRPC and Commons packages * Moved AnyCodable to Commons * Fixed test import * Reintroduces either type * Add request and response types * Add simple response decode tests * Add response ID parsing tests * Fixed tests typo * Improved response round trip coding test * Error response decoding tests * Invalid response decode tests * Enabled code coverage for library * Response decoding tests for structured result values * Add flexible initializers with tests * Add descriptions to errors thrown in response decoding * Renamed response internalResult to outcome * Basic RPC request decoding tests * Tests for request empty cases and corner cases * Add flexible inits for requests * Add identifier generation inits * Joined request notification extensions * Renamed files * Implemented default JSONRPC error cases * Declared RPCRequestConvertible as public * Remove rebase artifacts * Added debug description to request param primitives error Co-authored-by: Bartosz Rozwarski <bartus000@gmail.com> Co-authored-by: André Vants <MisterVants@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
deleteAll()methods added forKeyManagementService,PairingStorage,SessionStoragecleanup()method in public interface (for DEBUG)