Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tests #242

Merged
merged 9 commits into from
Jun 3, 2022
Merged

UI tests #242

merged 9 commits into from
Jun 3, 2022

Conversation

flypaper0
Copy link
Contributor

What changed

  • UITesting environment
  • TU001, TU002, TU004 cases covered
  • Alert on Ping response

Video
https://drive.google.com/file/d/11uRbgL1gZprK_LVotNO2oKy2Ml6dX_kI/view?usp=sharing

Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flypaper0 just FYI: tests fail to setup on my mac.

@llbartekll
Copy link
Contributor

more specifically apps deletion process

@Mike117687
Copy link

merge-these-changes

Sent with GitHawk

@flypaper0
Copy link
Contributor Author

more specifically apps deletion process

This is one of limitation of my approach. For now it only works with English OS language

@chadyj chadyj linked an issue May 31, 2022 that may be closed by this pull request
@chadyj
Copy link
Contributor

chadyj commented May 31, 2022

I think it is a good idea to integrate this into CI because we can test on multiple devices and OS versions. This will increase our testing surface and make it more likely we will spot edge cases.

During discussions we said this can happen only when merging to main, but out of curiosity, why not run e2e tests on every PR?

@flypaper0 flypaper0 requested a review from sekimondre May 31, 2022 11:17
@flypaper0 flypaper0 force-pushed the ui-tests branch 23 times, most recently from 556eb99 to ac73248 Compare May 31, 2022 16:13
@chadyj
Copy link
Contributor

chadyj commented May 31, 2022

Some suggestions from the cloud team:

Concurrency e.g. https://github.com/WalletConnect/registry-api-cf-workers/blob/master/.github/workflows/pr.yaml#L15
Personal preference: split up this CI/PR step into two distinct steps (gives you a clean status badge)

I think this can improve the build

- uses: actions/cache@v2
  with:
    path: Pods
    key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}
    restore-keys: |
            ${{ runner.os }}-pods-

Here is a good post about it https://benoitpasquier.com/tips-tweaks-github-action-ios/

@Mike117687
Copy link

merge-these-changes

@flypaper0
Copy link
Contributor Author

Some suggestions from the cloud team:

Concurrency e.g. https://github.com/WalletConnect/registry-api-cf-workers/blob/master/.github/workflows/pr.yaml#L15 Personal preference: split up this CI/PR step into two distinct steps (gives you a clean status badge)

I think this can improve the build

- uses: actions/cache@v2
  with:
    path: Pods
    key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}
    restore-keys: |
            ${{ runner.os }}-pods-

Here is a good post about it https://benoitpasquier.com/tips-tweaks-github-action-ios/

We use SMP instead of Cocoapods, but I understand the idea.
Created task for that #257

@flypaper0 flypaper0 merged commit 84307e0 into develop Jun 3, 2022
@flypaper0 flypaper0 deleted the ui-tests branch June 3, 2022 13:48
@flypaper0 flypaper0 mentioned this pull request Jun 9, 2022
flypaper0 added a commit that referenced this pull request Jun 9, 2022
* Cleanup Service + SequenceStore refactor (#241)

* Cleanup service

* Clean sessionToPairingTopic

* SequenceStore refactor

* Rename KeyValueStore -> CodableStore

* Deliver an invite (#254)

* Add Chat target, split packages

* savepoint

* Update networking interactor  to decode unencrypted messages

* pass on invite test

* restructure chat's project folder

* Add engine storages

* extract storage domain identifiers

* update logging

* fix schemas

* Update style

* Add publishers to Chat

* rename kv store to codable strore

* UI tests (#242)

* Pairing testcase

* Ping testcase

* ApproveSessionExistingPairing test case

* Unused extensions deleted

* Renamed to RegressionTests

* UITests step on CI

* CleanLaunch instead of deleting app

* Fix test on Real device

* Launch App fix

* Approve engine refactor (#260)

* Approve method moved ApproveEngine

* Reject and wcSessionSubscriptions for ApproveEngine

* Private methods moved in extension

* ApproveEngine errors handlers

* Try on reject

* ApproveEngine moved to callbacks

* Session Settle moved to approve Engine

* onProposeResponse subscription removed

* Reject by proposalId

* Settle moved to approve

* ApproveEngine moved to Controller folder

* typealias removed

* TODO for SettleEngine

* #256 JSON-RPC Package (& Commons) (#261)

* Add Chat target, split packages

* savepoint

* restructure chat's project folder

* fix schemas

* Add JSONRPC and Commons packages

* Moved AnyCodable to Commons

* Fixed test import

* Reintroduces either type

* Add request and response types

* Add simple response decode tests

* Add response ID parsing tests

* Fixed tests typo

* Improved response round trip coding test

* Error response decoding tests

* Invalid response decode tests

* Enabled code coverage for library

* Response decoding tests for structured result values

* Add flexible initializers with tests

* Add descriptions to errors thrown in response decoding

* Renamed response internalResult to outcome

* Basic RPC request decoding tests

* Tests for request empty cases and corner cases

* Add flexible inits for requests

* Add identifier generation inits

* Joined request notification extensions

* Renamed files

* Implemented default JSONRPC error cases

* Declared RPCRequestConvertible as public

* Remove rebase artifacts

* Added debug description to request param primitives error

Co-authored-by: Bartosz Rozwarski <bartus000@gmail.com>
Co-authored-by: André Vants <MisterVants@users.noreply.github.com>
@flypaper0 flypaper0 mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Testing
4 participants