Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approve engine refactor #260

Merged
merged 13 commits into from
Jun 8, 2022
Merged

Approve engine refactor #260

merged 13 commits into from
Jun 8, 2022

Commits on Jun 3, 2022

  1. Approve method moved ApproveEngine

    @flypaper0
    flypaper0 committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    543c5ca View commit details
    Browse the repository at this point in the history

  2. Reject and wcSessionSubscriptions for ApproveEngine

    @flypaper0
    flypaper0 committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    ed3f290 View commit details
    Browse the repository at this point in the history

  3. Private methods moved in extension

    @flypaper0
    flypaper0 committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    c8b3086 View commit details
    Browse the repository at this point in the history

  4. ApproveEngine errors handlers

    @flypaper0
    flypaper0 committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    2fc6791 View commit details
    Browse the repository at this point in the history

  5. Try on reject

    @flypaper0
    flypaper0 committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    d70ed7e View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. ApproveEngine moved to callbacks

    @flypaper0
    flypaper0 committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    e4d8fef View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Session Settle moved to approve Engine

    @flypaper0
    flypaper0 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    8533da5 View commit details
    Browse the repository at this point in the history

  2. onProposeResponse subscription removed

    @flypaper0
    flypaper0 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    3c3d9be View commit details
    Browse the repository at this point in the history

  3. Reject by proposalId

    @flypaper0
    flypaper0 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    4671a34 View commit details
    Browse the repository at this point in the history

  4. Settle moved to approve

    @flypaper0
    flypaper0 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    16336ca View commit details
    Browse the repository at this point in the history

  5. ApproveEngine moved to Controller folder

    @flypaper0
    flypaper0 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    0195083 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. typealias removed

    @flypaper0
    flypaper0 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ba3fb76 View commit details
    Browse the repository at this point in the history

  2. TODO for SettleEngine

    @flypaper0
    flypaper0 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    6bd3c6b View commit details
    Browse the repository at this point in the history