#chat/registry #262
#chat/registry #262
Conversation
llbartekll
commented
Jun 7, 2022
llbartekll
commented
- Add registry manager
- update client api with specs
- add Concurrency
| import WalletConnectUtils | ||
| import WalletConnectKMS | ||
|
|
||
| actor RegistryManager { |
There was a problem hiding this comment.
What the difference between Manager and Engine naming?
There was a problem hiding this comment.
I am always scratching my head when giving them a names. in this context it just sounds better to me. Any suggestions?
| } | ||
|
|
||
| override func tearDown() { | ||
| registry = nil |
There was a problem hiding this comment.
May be not necessary to set nil at tearDown ? We setting new value in setUp
| } | ||
|
|
||
| class KeyValueRegistry: Registry { | ||
| actor KeyValueRegistry: Registry { |
There was a problem hiding this comment.
What benefits actor gives us here?
We could make it class and make registryStore private. So it couldn't be mutated from outside too
There was a problem hiding this comment.
true it is better registryStore is private
but I think making it an actor gives thread safety
So it couldn't be mutated from outside too
It could be mutated by calling register() from different threads
anyway this class is mimicking an http client right now
llbartekll
force-pushed
the
#chat/registry
branch
from
b8da96d
to
f30f1f7
Compare
|
This PR is pointing to |
* Add registry manager * Update api methods * update resolve * Add description to api methods * update invite method * remove teardown * make registryStore private
