[Chat] feature/#244-create thread #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
llbartekll
commented
Jun 10, 2022
•
llbartekll
commented
- allows to create a thread for two peers
- still using old encryption policy
…V2 into #chat/accept-invite # Conflicts: # Sources/Chat/Chat.swift # Sources/Chat/Engine.swift # Sources/Chat/NetworkingInteractor.swift # Sources/Chat/Types/ChatRequest.swift # Sources/Chat/Types/Invite.swift # Tests/ChatTests/EndToEndTests.swift # Tests/ChatTests/Mocks/NetworkingInteractorMock.swift # Tests/ChatTests/RegistryManagerTests.swift
flypaper0
reviewed
Jun 17, 2022
| let registryManager: RegistryManager | ||
| let engine: Engine | ||
| let registryService: RegistryService | ||
| let invitationHandlingService: InvitationHandlingService |
There was a problem hiding this comment.
I like ***Service naming, let's use more often
flypaper0
reviewed
Jun 17, 2022
| @@ -5,12 +5,23 @@ import WalletConnectRelay | |||
| import WalletConnectUtils | |||
|
|
|||
| protocol NetworkInteracting { | |||
| func subscribe(topic: String) async throws | |||
| var requestPublisher: AnyPublisher<RequestSubscriptionPayload, Never> {get} | |||
There was a problem hiding this comment.
run swiftlint --fix please
flypaper0
approved these changes
Jun 17, 2022
…V2 into #chat/accept-invite # Conflicts: # Sources/Chat/Chat.swift # Sources/Chat/Engine.swift # Sources/Chat/NetworkingInteractor.swift # Sources/Chat/Types/ChatRequest.swift # Sources/Chat/Types/Invite.swift # Sources/WalletConnectKMS/Codec/ChaChaPolyCodec.swift # Tests/ChatTests/EndToEndTests.swift
Merged
llbartekll
added a commit
that referenced
this pull request
Jul 5, 2022
* Add registry manager * Update api methods * update resolve * Add description to api methods * update invite method * remove teardown * make registryStore private * update new thread e2e test * Add invite service * savepoint * Update invite service * Add invitation handling * test - decrypts an invite * savepoint * Accept and create a Thread on Invitee * savepoint * add json rpc history * savepoint * remove ChatRequest type * create a Thread on both peers * clean up * swiftlint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.