[Sign] Feature: #252 Update session namespaces checks against required namespaces #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 16, 2022 13:00
flypaper0
approved these changes
Jun 17, 2022
llbartekll
approved these changes
Jun 21, 2022
Merged
llbartekll
pushed a commit
that referenced
this pull request
Jul 5, 2022
…d namespaces (#276) * Set required namespaces in session creation * Add basic checks to required namespaces * Changed updateNamespaces to throw errors * Add basic tests for valid & invalid update * Add failure tests, implemented checks on namespace extensions * Test small improvements Co-authored-by: André Vants <andrevants@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #252
Changes
updateNamespacesnow throws and checks the namespaces against the required namespaces.Extensionnow has a superset check.updateNamespacessuccess and failure cases.