[Core] Feature/#273 envelope types #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix codec tests
flypaper0
reviewed
Jun 20, 2022
flypaper0
reviewed
Jun 20, 2022
flypaper0
reviewed
Jun 20, 2022
flypaper0
reviewed
Jun 20, 2022
flypaper0
reviewed
Jun 20, 2022
llbartekll
changed the title
flypaper0
approved these changes
Jun 21, 2022
…V2 into #273-encryption-policies # Conflicts: # Sources/Chat/NetworkingInteractor.swift # Sources/Chat/Serializing.swift # Sources/WalletConnectKMS/Codec/ChaChaPolyCodec.swift # Sources/WalletConnectKMS/Crypto/CryptoKitWrapper/CryptoKitWrapper.swift # Sources/WalletConnectKMS/Crypto/KeyManagementService.swift # Sources/WalletConnectKMS/Serialiser/Serializer.swift # Sources/WalletConnectSign/NetworkInteractor/NetworkInteractor.swift # Sources/WalletConnectSign/Serializing.swift # Tests/IntegrationTests/SerialiserTests.swift # Tests/TestingUtils/Mocks/KeyManagementServiceMock.swift # Tests/WalletConnectSignTests/Mocks/SerializerMock.swift
Merged
llbartekll
added a commit
that referenced
this pull request
Jul 5, 2022
* Add SerializationPolicy type * savepoint * savepoint * Add envelope * update serialize method * update envelope * handle envelope in Sign sdk * extract envelope to a new file * add getPublicKey method to kms * fix kms errors * fix kms tests * add kms tests scheme fix codec tests * fix serializer tests * update kms test, fix type 0 envelope key size issue * simplify serialiser, add envelope init * Fix envelope type, fix serialiser tests * remove debugging prints * update codec docs * remove unused error * remove unused error * move serializing protocol to serializer * prevent potential crash on envelope init * add serializing file * run lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds envelope types
close #273