[SDK] Inject WebSocket factory #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flypaper0
force-pushed
the
feature/inject-websocket-#275
branch
7 times, most recently
from
225901f
to
33c8285
Compare
llbartekll
approved these changes
Jun 24, 2022
| @@ -17,13 +17,28 @@ public class Sign { | |||
| guard let config = Sign.config else { | |||
| fatalError("Error - you must call configure(_:) before accessing the shared instance.") | |||
| } | |||
| relayClient = RelayClient(relayHost: "relay.walletconnect.com", projectId: config.projectId, socketConnectionType: config.socketConnectionType) | |||
| relayClient = RelayClient( | |||
| relayHost: "dev.relay.walletconnect.com", | |||
There was a problem hiding this comment.
we need to remember to change it to non dev before the release
sekimondre
approved these changes
Jun 24, 2022
flypaper0
force-pushed
the
feature/inject-websocket-#275
branch
from
33c8285
to
7be541f
Compare
Merged
llbartekll
pushed a commit
that referenced
this pull request
Jul 5, 2022
* WebSocketConnecting protocol injection * WebSocket Factory * Dapp and Wallet tests removed * Separate integration tests from SDK * Deployment target updated * Removing TestingUtills library * Task priority hight * Specify derivedDataPath * Switch to prod relay host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#275
What changed