[Core] Feature/#263 add SocketAuthenicator and JWT #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix codec tests
…V2 into #273-encryption-policies # Conflicts: # Sources/Chat/NetworkingInteractor.swift # Sources/Chat/Serializing.swift # Sources/WalletConnectKMS/Codec/ChaChaPolyCodec.swift # Sources/WalletConnectKMS/Crypto/CryptoKitWrapper/CryptoKitWrapper.swift # Sources/WalletConnectKMS/Crypto/KeyManagementService.swift # Sources/WalletConnectKMS/Serialiser/Serializer.swift # Sources/WalletConnectSign/NetworkInteractor/NetworkInteractor.swift # Sources/WalletConnectSign/Serializing.swift # Tests/IntegrationTests/SerialiserTests.swift # Tests/TestingUtils/Mocks/KeyManagementServiceMock.swift # Tests/WalletConnectSignTests/Mocks/SerializerMock.swift
llbartekll
force-pushed
the
#263-Add-client-id
branch
from
3c1e052
to
a624076
Compare
llbartekll
changed the title
flypaper0
reviewed
Jun 24, 2022
| @@ -0,0 +1,30 @@ | |||
| import Foundation | |||
|
|
|||
| struct JWT: Codable, Equatable { | |||
There was a problem hiding this comment.
may be split to JWT and SignedJWT ?
public func sign(jwt: JWT, using jwtSigner: JWTSigning) throws -> SignedJWT
or something like that
There was a problem hiding this comment.
If so, no need to modify alg inside Header. We could just recreate Header
flypaper0
reviewed
Jun 24, 2022
| enum Errors: Error { | ||
| case invalidJWTString | ||
| } | ||
| var alg = "EdDSA" |
There was a problem hiding this comment.
why alg everywhere is internal var?
flypaper0
reviewed
Jun 24, 2022
| var sut: ED25519DIDKeyFactoryImpl! | ||
|
|
||
| func test() { | ||
|
|
There was a problem hiding this comment.
implemented but the factory itself is not implemented - scope of #288
flypaper0
approved these changes
Jun 24, 2022
Merged
llbartekll
added a commit
that referenced
this pull request
Jul 5, 2022
* Add SerializationPolicy type * savepoint * savepoint * Add envelope * update serialize method * update envelope * handle envelope in Sign sdk * extract envelope to a new file * add getPublicKey method to kms * fix kms errors * fix kms tests * add kms tests scheme fix codec tests * fix serializer tests * update kms test, fix type 0 envelope key size issue * simplify serialiser, add envelope init * Fix envelope type, fix serialiser tests * remove debugging prints * update codec docs * remove unused error * remove unused error * move serializing protocol to serializer * prevent potential crash on envelope init * add serializing file * run lint * Add client auth core components * Add client auth mocks * Add signing private key * Add signing crypto kit wrapper * Add Socket Authenticator Test * update SocketAuthenticator * savepoint * savepoint * pass jwt test * extract jwt encoder * savepoint * update signer * fix tests * extract ED25519DIDKeyFactoryMock * clean up * remove commented code * run lint fix * change relay url * test * update relay url * test * test * revert * test * fix typo * savepoint * Update ED25519DIDKeyFactoryTests * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SocketAuthenicator, JWT, JWT signer for client authentication on Iridium with unit tests for dependant components.
close #284
close #285
close #286
close #287