Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve semantics for requesting wc methods from the engine and remove completion blocks for response handling. Provides an abstraction to prevent creating request objects where the method doesn't match the parameters sent.
WCMethod
to pass the method parameters to the relayer and simplify the request call.WCRequest
from the engine.completion
parameter on theWalletConnectRelaying
request method to become optional. This change prepares the code to gradually remove all completion handlers used for responses in the engines.