Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine request improvement #30

Merged
merged 7 commits into from
Jan 18, 2022
Merged

Engine request improvement #30

merged 7 commits into from
Jan 18, 2022

Conversation

sekimondre
Copy link

Improve semantics for requesting wc methods from the engine and remove completion blocks for response handling. Provides an abstraction to prevent creating request objects where the method doesn't match the parameters sent.

  • Adds WCMethod to pass the method parameters to the relayer and simplify the request call.
  • Removes the need to always match parameters pairs when creating a WCRequest from the engine.
  • Changes the completion parameter on the WalletConnectRelaying request method to become optional. This change prepares the code to gradually remove all completion handlers used for responses in the engines.

@sekimondre sekimondre merged commit b3b53a7 into develop Jan 18, 2022
@sekimondre sekimondre deleted the wc-request-improvement branch January 18, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants