Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Cocoapods support #258 #569

Merged
merged 20 commits into from
Nov 8, 2022
Merged

[Infra] Cocoapods support #258 #569

merged 20 commits into from
Nov 8, 2022

Conversation

flypaper0
Copy link
Contributor

@flypaper0 flypaper0 commented Nov 4, 2022

Description

  • Podspec file
  • File duplicates removed
  • *Imports.swift files for @_exported imports

Resolves #258 (issue)

How Has This Been Tested?

Cocoapods integration can be tested on v1.0.5-rc tag

pod 'WalletConnectSwiftV2', :git => 'https://github.com/WalletConnect/WalletConnectSwiftV2.git', :tag => 'v1.0.5-rc'

Due Dilligence

  • Breaking change
  • Requires a documentation update

@smallerboy
Copy link

it's great !

@smallerboy
Copy link

smallerboy commented Nov 4, 2022

some file miss, just like Sign and Auth Package

@flypaper0 flypaper0 marked this pull request as draft November 7, 2022 10:49
@flypaper0
Copy link
Contributor Author

some file miss, just like Sign and Auth Package

Good catch, fixed. There was wrong source paths.

Released new tag:

pod 'WalletConnectSwiftV2', :git => 'https://github.com/WalletConnect/WalletConnectSwiftV2.git', :tag => 'v1.0.5-rc3'

Regarding Auth. Auth is available buy downloading subspec.

pod 'WalletConnectSwiftV2/WalletConnectAuth', :git => 'https://github.com/WalletConnect/WalletConnectSwiftV2.git', :tag => 'v1.0.5-rc3'

@flypaper0 flypaper0 marked this pull request as ready for review November 7, 2022 11:42
@flypaper0 flypaper0 merged commit 07cdbc5 into develop Nov 8, 2022
@flypaper0 flypaper0 deleted the feature/cocoapods-#258 branch November 8, 2022 08:11
@syp1027825441
Copy link

syp1027825441 commented Dec 4, 2022

the demo can not use,by cocoapods version. Error Tips 'No such module 'WalletConnectSign''

@smallerboy
Copy link

the demo can not use,by cocoapods version. Error Tips 'No such module 'WalletConnectSign''

maybe you can import walletConnectv2 replace 'WalletConnectSign'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants