#50 Update error reason codes #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
approved these changes
Jan 31, 2022
Comment on lines
+16
to
+20
| case .generic: return 0 | ||
| case .invalidUpdateRequest: return 1003 | ||
| case .noContextWithTopic: return 1301 | ||
| case .unauthorizedUpdateRequest: return 3003 | ||
| case .unauthorizedMatchingController: return 3005 |
There was a problem hiding this comment.
are these codes compatible with js already?
There was a problem hiding this comment.
They follow the defined reason codes, I'll add them to a RPC docs to be agreed by all platforms.
| @@ -1,4 +1,5 @@ | |||
| import Foundation | |||
| import Network | |||
There was a problem hiding this comment.
is this import intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds required error codes to responses sent by peer client when errors happens during an update call.