#54 Public account type #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MisterVants that is pr into main, change for develop |
done |
hewigovens
approved these changes
Feb 9, 2022
| @@ -150,8 +150,8 @@ extension ResponderViewController: SessionViewControllerDelegate { | |||
| print("[RESPONDER] Approving session...") | |||
| let proposal = currentProposal! | |||
| currentProposal = nil | |||
| let accounts = proposal.permissions.blockchains.map {$0+":\(account)"} | |||
| client.approve(proposal: proposal, accounts: Set(accounts)) | |||
| let accounts = Set(proposal.permissions.blockchains.compactMap { Account($0+":\(account)") }) | |||
There was a problem hiding this comment.
can we add another convenience init to avoid passing the : , It looks easy to forget
There was a problem hiding this comment.
I added two more init to make the type more flexible.
Sources/WalletConnect/Account.swift
Outdated
| public struct Account: Equatable, Hashable { | ||
|
|
||
| /// A blockchain namespace. Usually describes an ecosystem or standard. | ||
| public var namespace: String |
There was a problem hiding this comment.
Let's use let for stored properties? immutable is better
llbartekll
approved these changes
Feb 10, 2022
| This initializer returns nil if the string doesn't represent a valid account id in conformance with | ||
| [CAIP-10](https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-10.md). | ||
| */ | ||
| public init?(_ string: String) { |
There was a problem hiding this comment.
maybe it would make sense to create a Chain and add init from a chain and an address.
There was a problem hiding this comment.
Makes sense, but IMHO only if we use the Chain type in more places in the engine. Sounds like an overkill if we add it just to use in an Account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #54
Adds a public
Accounttype to handle CAIP-10 account ids when making SDK calls.