Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11 auto/manual socket connection #66

Merged
merged 22 commits into from
Feb 9, 2022

Conversation

llbartekll
Copy link
Contributor

@llbartekll llbartekll commented Feb 7, 2022

close #11
does not update public interface

edit:

  • allows to inject relayer instance into client
  • expose connect/disconnect on relayer

@llbartekll llbartekll closed this Feb 8, 2022
@llbartekll llbartekll reopened this Feb 8, 2022
@llbartekll llbartekll changed the base branch from main to develop February 8, 2022 09:40
@llbartekll llbartekll self-assigned this Feb 9, 2022
}

func send(_ string: String, completion: @escaping (Error?) -> Void) {
if socket.isConnected {
self.socket.send(string, completionHandler: completion)
//TODO - enqueue if fails

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

import Foundation
@testable import Relayer

class BackgroundTaskRegistrarMock: BackgroundTaskRegistering {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a typo here

@sekimondre sekimondre merged commit 047b08c into develop Feb 9, 2022
@sekimondre sekimondre deleted the #11-auto/manual-socket-connection branch February 9, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide manual network connection control
2 participants