[Chat] Identity and Invite keys registration #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flypaper0
changed the title
llbartekll
approved these changes
Feb 9, 2023
Comment on lines
-30
to
+34
| private let messageFormatter: SIWEMessageFormatting | ||
| private let messageFormatter: SIWECacaoFormatting |
There was a problem hiding this comment.
it was called SIWEMessageFormatting because siwe message does not know anything about cacao, not sure if it's better name
Comment on lines
-19
to
+23
| public typealias AuthMessageSigner = MessageSignatureVerifying & MessageSigning | ||
| public typealias CacaoMessageSigner = MessageSignatureVerifying & MessageSigning |
There was a problem hiding this comment.
same here CacaoMessageSigner couples this to cacao object but it doesn't have to be wrapped into cacao
There was a problem hiding this comment.
also fix at another PR
Comment on lines
+37
to
+39
| public var iss: String { | ||
| return DIDPKH(account: self).iss | ||
| } |
There was a problem hiding this comment.
what is this used for? what if you want an issuer in with different did method not pkh?
There was a problem hiding this comment.
I'll rename it into string in another PR, to not catch the conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence