Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new methods to web3wallet #731

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Expose new methods to web3wallet #731

merged 1 commit into from
Feb 24, 2023

Conversation

alexander-lsvk
Copy link
Contributor

Due Dilligence

Related to the topic:

Hey guys, related to Web3Wallet on iOS.
There are a lot of methods/combine publishers that we're currently using (From Sign and Pair targets) but they are not included in the Web3Wallet target and we need to import the other packages in order to make it work
Can we include them in the new SDK?

Sign
socketConnectionStatusPublisher
sessionSettlePublisher
sessionDeletePublisher
sessionResponsePublisher
cleanup

Pair
getPairings()
  • Breaking change
  • Requires a documentation update

}
.store(in: &disposeBag)

let expectation = expectation(description: "Fail after 0.1s timeout")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be move it in TestingUtills?
like

extension XCTestCase {
  func waitExpectation(timeout: TimeInterval)
}

@llbartekll llbartekll merged commit 89fab4c into develop Feb 24, 2023
@llbartekll llbartekll deleted the w3w-new-methods branch February 24, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants