[Relay] Regenerate socket URL on error disconnection #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-lsvk
changed the title
flypaper0
reviewed
Mar 30, 2023
flypaper0
reviewed
Mar 30, 2023
flypaper0
reviewed
Mar 30, 2023
flypaper0
reviewed
Mar 30, 2023
llbartekll
reviewed
Apr 3, 2023
| try socketConnectionHandler?.handleDisconnect(closeCode: closeCode) | ||
| } | ||
|
|
||
| private func setUpSocketConnection() { |
There was a problem hiding this comment.
is this function called by anyone?
llbartekll
reviewed
Apr 3, 2023
Comment on lines
142
to
143
| host: relayHost, | ||
| projectId: projectId |
There was a problem hiding this comment.
could we maybe add host and projectId to the url factory init? they wan't change anyway
llbartekll
reviewed
Apr 3, 2023
Comment on lines
83
to
86
| let dispatcher = Dispatcher( | ||
| relayHost: relayHost, | ||
| projectId: projectId, | ||
| clientIdStorage: clientIdStorage, |
There was a problem hiding this comment.
would adding RelayClientFactory, like we have for other clients solve the init problem for Dispatcher and RelayClient?
llbartekll
reviewed
Apr 4, 2023
| var socket: WebSocketConnecting | ||
| var socketConnectionHandler: SocketConnectionHandler | ||
|
|
||
| var socket: WebSocketConnecting? |
There was a problem hiding this comment.
does it have to be optional?
llbartekll
approved these changes
Apr 7, 2023
flypaper0
approved these changes
Apr 10, 2023
|
lgtm, I think it's better to recreate websocket instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Dilligence