[W3W] Add pending proposals #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Example/WalletApp/PresentationLayer/Wallet/Wallet/WalletView.swift # Sources/WalletConnectSign/Engine/Common/ApproveEngine.swift # Sources/WalletConnectSign/Sign/SignClientFactory.swift
llbartekll
reviewed
May 24, 2023
There was a problem hiding this comment.
there are unresolved comments in your previous PR
#744
wouldn't it be easier to reopen the last one so we can continue discussion?
flypaper0
reviewed
Jun 8, 2023
|
|
||
| requestSubscriptionPayloads.forEach { | ||
| let proposal = $0.request | ||
| proposalPayloadsStore.set($0, forKey: proposal.proposer.publicKey) |
There was a problem hiding this comment.
where are we reading from that store? Couldn't find
# Conflicts: # Sources/Auth/AuthClientFactory.swift # Sources/Auth/Services/Wallet/WalletRequestSubscriber.swift # Sources/WalletConnectSign/Engine/Common/ApproveEngine.swift # Sources/WalletConnectSign/Engine/Common/SessionEngine.swift # Sources/WalletConnectSign/Sign/SignClientFactory.swift # Tests/AuthTests/WalletRequestSubscriberTests.swift # Tests/WalletConnectSignTests/SessionEngineTests.swift
flypaper0
reviewed
Jul 20, 2023
Sources/Auth/AuthClientFactory.swift
Outdated
| @@ -1,15 +1,15 @@ | |||
| import Foundation | |||
|
|
|||
| public struct AuthClientFactory { | |||
| import WalletConnectVerify | |||
flypaper0
reviewed
Jul 20, 2023
| /// - Parameter id: id of a wc_sessionRequest jsonrpc request | ||
| /// - Returns: json rpc record object for given id or nil if record for give id does not exits | ||
| public func getSessionRequestRecord(id: RPCID) -> Request? { | ||
| public func getSessionRequestRecord(id: RPCID) -> (request: Request, context: VerifyContext?)? { |
There was a problem hiding this comment.
What do you think about separate getVerifyContext(id: RPCID).
To not affect current Client interface
There was a problem hiding this comment.
Let's discuss it on sync
flypaper0
reviewed
Jul 20, 2023
| @@ -1,5 +1,7 @@ | |||
| import Foundation | |||
|
|
|||
| import WalletConnectVerify | |||
# Conflicts: # Sources/Auth/Services/Wallet/WalletRequestSubscriber.swift # Sources/WalletConnectSign/Engine/Common/SessionEngine.swift
flypaper0
approved these changes
Jul 27, 2023
llbartekll
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence