[W3M] UI + Sign integration #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,14 @@ | |||
| import SwiftUI | |||
|
|
|||
| struct ActivityIndicator: UIViewRepresentable { | |||
There was a problem hiding this comment.
yeah ProgressView is iOS 14 :|
| } | ||
|
|
||
| private func closeButton() -> some View { | ||
| Button(action: { |
There was a problem hiding this comment.
Button {
// action
} label: {
// view
}
Not critical but a bit cleaner, if you like
| viewModel.navigateTo(.qr) | ||
| } | ||
| }, label: { | ||
| Image("qr_large", bundle: .module) |
There was a problem hiding this comment.
I assume it's not final etc, but would be nice to have all the assets to be stored in i.e. enum in the future.
enum Icons {
static let qrLarge = "qrLarge"
}
...
Image(Icons.qrLarge)
|
|
||
| private func copyButton() -> some View { | ||
| Button(action: { | ||
| UIPasteboard.general.string = viewModel.uri |
There was a problem hiding this comment.
Maybe it's better to call this on ViewModel so we can test it
| .frame(height: 60) | ||
| .overlay( | ||
| Text(viewModel.destination.contentTitle) | ||
| .font(.system(size: 20).weight(.semibold)) |
There was a problem hiding this comment.
Same: some data structure for the fonts would be more convenient
There was a problem hiding this comment.
Will do once there is some clear typography defined in figma which is not the case afaik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented-out code depends on Networking changes which will be in the next PR