[W3M] Fetching and displaying wallets #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeknovis
force-pushed
the
feature/w3m-networking
branch
from
6be534d
to
68051e0
Compare
radeknovis
changed the title
| .target( | ||
| name: "WalletConnectNetworking", | ||
| dependencies: ["WalletConnectRelay"]), | ||
| dependencies: ["HTTPClient", "WalletConnectRelay"]), |
There was a problem hiding this comment.
Doest it work with CocoaPods?
There was a problem hiding this comment.
@radeknovis you can ping me in slack, and I can explain how we are setting up cocoapods dependencies
There was a problem hiding this comment.
I've updated the pod spec accordingly now. TA for help @flypaper0
radeknovis
force-pushed
the
feature/w3m-networking
branch
from
f4be7cc
to
afdc8cd
Compare
alexander-lsvk
approved these changes
May 24, 2023
flypaper0
reviewed
May 24, 2023
| @@ -0,0 +1,12 @@ | |||
| import SwiftUI | |||
|
|
|||
| private struct ProjectIdKey: EnvironmentKey { | |||
There was a problem hiding this comment.
looks nice, where it's using?
There was a problem hiding this comment.
Yeah I thought about using it to set projectID but didn't end up using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description