Switch try! for try in NetworkingInteractor respond method #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
approved these changes
May 24, 2023
|
Can i please get more info on how to pass CI ? @llbartekll |
|
@BornaMajstorovic we had to make some changes to our CI to fix it for external PRs. Do you mind closing and reopening the PR so these changes take effect? |
Some steps are still failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
NetworkingInteractorfunc respond(topic, response, protocolMethod, envelopeType)is marked withthrows, but there was stilltry!which would sometimes fail and crash the app, since method is marked with throws there should be no need to crash the app if try fails withWalletConnectKMS.Serializer.Errors.symmetricKeyForTopicNotFounderror