[W3M] Deeplinking to wallets #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeknovis
force-pushed
the
feature/w3m-deeplinking
branch
3 times, most recently
from
db3b57f
to
2fca437
Compare
radeknovis
force-pushed
the
feature/w3m-deeplinking
branch
from
2fca437
to
2d32f54
Compare
flypaper0
reviewed
May 25, 2023
| @@ -22,23 +22,31 @@ extension ModalSheet { | |||
| } | |||
|
|
|||
| final class ModalViewModel: ObservableObject { | |||
There was a problem hiding this comment.
why viewModel is a part of extension to ModalSheet?
There was a problem hiding this comment.
I initially thought about namespacing it by using that extension. So you don't have to prefix every type with ModalXxx but it's probably premature right now and going to remove it.
flypaper0
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds deeplink capability to wallets show in first screen
How Has This Been Tested?
Added unit tests to verify encoding of URL to be opened as deeplink