#888 w3i date encoding #894
Conversation
| @@ -167,6 +167,7 @@ final class PushTests: XCTestCase { | |||
| return | |||
| } | |||
| subscriptionTopic = pushSubscription.topic | |||
| sleep(1) | |||
There was a problem hiding this comment.
nit: can you leave context here of why this is required and what is being fixed?
There was a problem hiding this comment.
So, when dapp receives proposal response and subscribes to push subscription topic, wallet immediately calls delete() method(not waiting for dapp's subscribe response). And usually dapp can subscribe before wallet publishes pushDelete but rarely delete reaches relay before dapp is able to subscribe and pushDelete payload is never delivered to a dapp.
This won't happen in real world and is just an effect of test design and immediate function calls. Push is not natively supported for dapps at the moment. Dapp client is implemented mostly for tests.
1 second delay of pushDelete method call should eliminate futur test fails.
Description
Resolves #888
How Has This Been Tested?
Due Dilligence