Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Add Relay Client factory #932

Merged
merged 5 commits into from
Jun 29, 2023
Merged

[Core] Add Relay Client factory #932

merged 5 commits into from
Jun 29, 2023

Conversation

llbartekll
Copy link
Contributor

@llbartekll llbartekll commented Jun 28, 2023 •
edited
Loading

Description

Adds Relay client factory

Resolves # (issue)

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

@llbartekll llbartekll temporarily deployed to internal June 28, 2023 12:56 — with GitHub Actions Inactive
@llbartekll llbartekll marked this pull request as draft June 28, 2023 12:57
@llbartekll llbartekll temporarily deployed to internal June 29, 2023 06:34 — with GitHub Actions Inactive
@llbartekll llbartekll marked this pull request as ready for review June 29, 2023 06:34
@llbartekll llbartekll changed the title Relay factory [Core] Add Relay factory Jun 29, 2023
@llbartekll llbartekll changed the title [Core] Add Relay factory [Core] Add Relay Client factory Jun 29, 2023
@llbartekll llbartekll temporarily deployed to internal June 29, 2023 07:01 — with GitHub Actions Inactive
alexander-lsvk
alexander-lsvk approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@alexander-lsvk alexander-lsvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to get conflicts in NativeSocket PR 😁

@llbartekll llbartekll merged commit 39494ba into develop Jun 29, 2023
8 checks passed
@llbartekll llbartekll deleted the relay-factory branch June 29, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-lsvk alexander-lsvk alexander-lsvk approved these changes

@radeknovis radeknovis radeknovis approved these changes

@flypaper0 flypaper0 Awaiting requested review from flypaper0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llbartekll @alexander-lsvk @radeknovis