Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aprove session properties #936

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Aprove session properties #936

merged 5 commits into from
Jul 3, 2023

Conversation

alexander-lsvk
Copy link
Contributor

@alexander-lsvk alexander-lsvk commented Jun 30, 2023 •
edited
Loading

Description

  • Approve sessionProperties
  • Expose requiredNamespaces to the Session object
  • Expose topic to the AuthRequest in order to be able to get the requester metadata

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

@alexander-lsvk alexander-lsvk temporarily deployed to internal June 30, 2023 06:51 — with GitHub Actions Inactive
@alexander-lsvk alexander-lsvk temporarily deployed to internal July 1, 2023 19:26 — with GitHub Actions Inactive
@alexander-lsvk alexander-lsvk temporarily deployed to internal July 2, 2023 19:51 — with GitHub Actions Inactive
@alexander-lsvk alexander-lsvk temporarily deployed to internal July 2, 2023 19:56 — with GitHub Actions Inactive
@alexander-lsvk alexander-lsvk temporarily deployed to internal July 3, 2023 06:12 — with GitHub Actions Inactive
@alexander-lsvk alexander-lsvk merged commit dfd5be0 into develop Jul 3, 2023
8 checks passed
@alexander-lsvk alexander-lsvk deleted the aprove-session-properties branch July 3, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

@flypaper0 flypaper0 Awaiting requested review from flypaper0

@radeknovis radeknovis Awaiting requested review from radeknovis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-lsvk @llbartekll