[WCM] Landscape improvements #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeknovis
force-pushed
the
feat/wcm-landscape-fix
branch
from
7d01ca3
to
06d4628
Compare
flypaper0
reviewed
Jul 18, 2023
flypaper0
reviewed
Jul 18, 2023
| } | ||
| .transform { | ||
| #if os(iOS) | ||
| $0.autocapitalization(.none) |
There was a problem hiding this comment.
why autocapitalization is inside transform?
There was a problem hiding this comment.
For some reason, autocapitalization is not available on macOS, so I had to wrap it in this #if os() and this transform helper method allows to do that inline rather than having the entire view duplicated with if/else.
However I've change the condition to really reflect the problem, and add #if not macOS
There was a problem hiding this comment.
The transform method is really this simple
func transform(@ViewBuilder _ transform: (Self) -> some View) -> some View {
transform(self)
}
flypaper0
reviewed
Jul 18, 2023
flypaper0
reviewed
Jul 18, 2023
flypaper0
reviewed
Jul 18, 2023
radeknovis
force-pushed
the
feat/wcm-landscape-fix
branch
from
0647a44
to
e1a6964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.