feat(monitoring): disabling container insights #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
force-pushed
the
feat/prometheus_mem_usage
branch
2 times, most recently
from
ebbea93
to
539ede1
Compare
geekbrother
force-pushed
the
feat/disable_container_insights
branch
from
8c9be8a
to
34f79b1
Compare
geekbrother
changed the base branch from
feat/prometheus_mem_usage
to
master
geekbrother
force-pushed
the
feat/disable_container_insights
branch
from
34f79b1
to
e6e9af1
Compare
chris13524
reviewed
Feb 24, 2024
| setting { | ||
| name = "containerInsights" | ||
| value = "enabled" | ||
| value = "disabled" |
There was a problem hiding this comment.
What does autoscaling trigger on then?
There was a problem hiding this comment.
Disabling ContainerInsights should not hurt the Fargate autoscaling, because for the autoscaling the AWS Predefined Scaling Metric is used which is different from the ContainerInsights.
We are using target_tracking_scaling_policy_configuration with the ECSServiceAverageCPUUtilization | ECSServiceAverageMemoryUtilization.
nopestack
approved these changes
Feb 24, 2024
arein
approved these changes
Feb 26, 2024
geekbrother
force-pushed
the
feat/disable_container_insights
branch
from
e6e9af1
to
24ec49c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables AWS CloudWatch Container Insights for the ECS after the CPU #528 and Memory #529 metrics are migrated to the Prometheus and we don't need the Container Insights anymore.
The following changes are made:
Bumpci_workflowstag to0.2.6,containerInsightstodisable.How Has This Been Tested?
Not tested.
Merging dependency policy 🚧
Due Diligence