Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(monitoring): disabling container insights #530

Merged
merged 1 commit into from
Apr 3, 2024
Merged

feat(monitoring): disabling container insights #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion terraform/ecs/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@ resource "aws_ecs_cluster" "app_cluster" {
}

# Exposes metrics such as the number of running tasks in CloudWatch
# Should be disabled because we use Prometheus for CPU and Memory monitoring
setting {
name = "containerInsights"
value = "enabled"
value = "disabled"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does autoscaling trigger on then? https://github.com/WalletConnect/blockchain-api/blob/cd66e9cebf9a1f9f91b009e7690a0217c46355a7/terraform/ecs/cluster_autoscaling.tf#L18

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling ContainerInsights should not hurt the Fargate autoscaling, because for the autoscaling the AWS Predefined Scaling Metric is used which is different from the ContainerInsights.
We are using target_tracking_scaling_policy_configuration with the ECSServiceAverageCPUUtilization | ECSServiceAverageMemoryUtilization.

}
}

Expand Down
Loading