Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): disabling container insights check in aquasecurity #5

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Feb 21, 2024

This PR disables the check for the AWS CloudWatch Container Insights in aquasecurity Terraform checker.

The reason to disable the Container Insights is that we are using only CPU and Memory utilization from it and we are moving to use the Prometheus instead. The full context.

When this check is on, there is an error in the CI workflow.

Testing

Not tested, but got an example of how it should look like.

Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekbrother geekbrother merged commit 26e8cc3 into main Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants