Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send message to parent page on load #46

Merged
merged 1 commit into from
Aug 9, 2023
Merged

feat: send message to parent page on load #46

merged 1 commit into from
Aug 9, 2023

Conversation

ganchoradkov
Copy link
Member

Description

Served JS now sends a message to the parent page notifying the SDK that the iframe has loaded instead of relying on onload/onerror events

How Has This Been Tested?

dogfooding

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@ganchoradkov ganchoradkov self-assigned this Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@arein arein added the accepted The issue has been accepted into the project label Aug 9, 2023
@ganchoradkov ganchoradkov merged commit d7ea55b into main Aug 9, 2023
7 of 8 checks passed
@ganchoradkov ganchoradkov deleted the feat/notify-sdk-on-iframe-load branch August 9, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDarksome xDarksome xDarksome approved these changes

Assignees

@ganchoradkov ganchoradkov

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganchoradkov @xDarksome @arein