Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in dataset_hw.py #34

Open
huizhang0110 opened this issue Nov 27, 2020 · 2 comments
Open

Bug in dataset_hw.py #34

huizhang0110 opened this issue Nov 27, 2020 · 2 comments

Comments

@huizhang0110
Copy link

Hi, thanks for your impressive work, I am really interested in it.
But when I test your code with the released model, I found that there is a small bug in dataset_hw.py.
Specifically, no locking mechanism for self.idx in class LineGenerate, which will cause an error when running in parallel.
The true testing results may be a little lower than your paper reported.

num_workers is set to 2 as your code
image

when num_workers = 1
image

@Wang-Tianwei
Copy link
Owner

Thank you for discovering this bug, I didn't notice it before~

@huizhang0110
Copy link
Author

Thanks for your reply,
and I wonder if a similar situation applies to RIMES?
If so, could you please provide the corrected result on RIMES or the corresponding checkpoints?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants