Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitch actions not showing you're not authenticated anymore #1011

Closed
Destroy666x opened this issue Feb 8, 2024 · 4 comments · Fixed by #1012 or #1013
Closed

Twitch actions not showing you're not authenticated anymore #1011

Destroy666x opened this issue Feb 8, 2024 · 4 comments · Fixed by #1012 or #1013

Comments

@Destroy666x
Copy link
Contributor

Destroy666x commented Feb 8, 2024

Describe the bug
It briefly appears and then disappears. Nothing appears in the dropdown. Search "works" but the results are added to that popup. See comment below

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to pick a Twitch category
  2. Nothing appears in dropdown

Expected behavior
Dropdown should be filled

Logs
https://obsproject.com/logs/tf1ZNope8LYLflFH

Version information

  • OS: Windows 10
  • OBS Version: 30.0.2
  • Plugin Version: latest template one

Additional context
I'll check quickly what it could be as I really need this functionality, but a lot changed so not sure I'll find the culprit.

@Destroy666x
Copy link
Contributor Author

Destroy666x commented Feb 8, 2024

Never mind. Just noticed this is a different bug/not great behavior. I was not authenticated (I guess loading backup removed the token or it expired). But it showed that nowhere in the UI. I remember there was a red warning for insufficient permissions. I think it should also cover the case of losing authentication.

@Destroy666x Destroy666x changed the title Twitch categories popup not appearing Twitch actions not showing you're not authenticated anymore Feb 8, 2024
@WarmUpTill WarmUpTill linked a pull request Feb 8, 2024 that will close this issue
@WarmUpTill
Copy link
Owner

WarmUpTill commented Feb 8, 2024

I added more warnings in the linked PR, which will display a warning if the token is expired or no token is selected at all.

@Destroy666x
Copy link
Contributor Author

Destroy666x commented Feb 8, 2024

Ah. I see we made PRs with different approaches:

  • yours has better UX and messages
  • mine has better coverage as there are more places that use those token checking functions

Something in the middle would probably be best

@WarmUpTill
Copy link
Owner

I would simply merge both.
I can't see any obvious conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants