Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline script: Rundir copies data files in wrong subdirectory #884

Closed
Oekn5w opened this issue Sep 30, 2023 · 2 comments · Fixed by #1008
Closed

Pipeline script: Rundir copies data files in wrong subdirectory #884

Oekn5w opened this issue Sep 30, 2023 · 2 comments · Fixed by #1008

Comments

@Oekn5w
Copy link
Contributor

Oekn5w commented Sep 30, 2023

Describe the bug
As I don't have a fully set up development environment for OBS, I am using the buildscripts from the Github actions to compile and install the plugin for testing.

For Windows using the RelWithDebInfo configuration the locale files are installed to

build_<arch>\rundir\<config>\data\obs-plugins\advanced-scene-switcher\data\locale

The expected directory is:

build_<arch>\rundir\<config>\data\obs-plugins\advanced-scene-switcher\locale

Interestingly, the release folder has the correct file structure for the resources and locale definitions.

The effect is that the plugin cannot find the translation tables if not copied manually to the correct folder.
("Failed to find plug-in's 'data' directory." warning)

To Reproduce
Steps to reproduce the behavior:

  1. On Windows run .github\scripts\Build-Windows.ps1
  2. Copy the rest of OBS into the rundir directory accordingly and start OBS
  3. Go to the tools' settings

Expected behavior
Not needing the manual copy operation.

Logs
N/A

Version information

  • OS: Windows 10
  • OBS Version 29.1.3
  • Plugin Version 1.24.0-beta1-2-gb1489d98

Additional context
I'd happily fix this myself, but I don't have sufficient cmake knowledge and I could not identify the relevant definitions.

@WarmUpTill
Copy link
Owner

I think this might just be the behaviour of the ObsPluginHelpers.cmake helpers.
I will try to look into it if I find the time to - just have to make sure that I am not breaking the "in-tree" builds with any changes there.

@WarmUpTill WarmUpTill linked a pull request Feb 4, 2024 that will close this issue
@WarmUpTill
Copy link
Owner

This might (finally) be solved once I switch to the new version of the OBS plugin template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants