Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Remux Condition #893

Open
DanielLester83 opened this issue Oct 3, 2023 · 7 comments · May be fixed by #918
Open

[Feature Request] Add Remux Condition #893

DanielLester83 opened this issue Oct 3, 2023 · 7 comments · May be fixed by #918

Comments

@DanielLester83
Copy link

Is your feature request related to a problem? Please describe.
I run a "check video" macro that launches vlc with the most recent remuxed recording, however it somtime fails as the remux hasn't completed yet.

Describe the solution you'd like
A Condition that triggers on the completion or start of the remux process.

Describe alternatives you've considered
adding arbitray long wait times.

@WarmUpTill WarmUpTill linked a pull request Nov 26, 2023 that will close this issue
@WarmUpTill
Copy link
Owner

I added the following option to the "Recording" condition type in the linked PR:
image

A build will be available here in a few minutes:
https://github.com/WarmUpTill/SceneSwitcher/actions/runs/6992382071?pr=918

I would appreciate if you could give this a try and report back if everything works as expected.
And sorry for taking so long to get back to you!

@DanielLester83
Copy link
Author

Unfortunately it seems to trigger at the beginning of the save or Remux proccess instead of the expected end (100%) of the Remux process.

@WarmUpTill
Copy link
Owner

That is unfortunate :(
I was hoping that the output signal handler would only send the corresponding signal when the processing is done.

I will try to think of a different way.

Thanks for the test!

@DanielLester83
Copy link
Author

Here is the macro I am using if it helps. It Launches VLC on my 2nd monitor when VLC isnt already runing. It determines the most recent recording based on "Name" & "Episode" variables that are saved/loaded form text files in other macros.

AAAQFXic7VdbbyM1FP4rxlohWJo2SSvBRuKhZLslUm8iu0WIVMiZOZmx6tjG9qRZonnb533klT/BL+IX8BM4x3NpLmp5Q0vVhyiec79858x4xeciccbzwc8rrsUc+IAPc0hu2bVMwfA9bkXhkRpcAfTghFKg+GAmlEeC0cNc6KwV8LfSniwhudTjIFxoyJkzhW2VUpPcjiEEqTN0vOIOMukDuFYgF/6HQn9XhGB0YwJpVxTKDhUdhcKfielaWLnMcoW/MJoNjU5lkEb7t6jRSrjG/ltYYpgc/TXJbtCjT+QUepf3rqIhN9lwUkVUC21w35DzTXa5V7XgOCGJNtqxVTJgTa6Mj8+xQZYa1e92y73m3P+mvKkNnKDpysjDur1X97pd0mxK/70Jt/Det+WJiVVE1L5p818nBZNlCq62yffZRr+JUUpYD2lrW+IRHSfGpYgArI8ymUwwIERG4QSpnptUziQhYsWDnMMvaNQHJ6QOUc4DeYngWQhFbW0P3X3kh/eWjiXFLSuVBTgfa9ErkeyxByhxSNV4IELrTALe38fX6x7+hxE27gd8oZJ9WBLMZiYpmh5R90Tyr3VeCCfFVJE2aDqkzeg0nItq6k+s9CYluYbRrzkjjYHLlEW6mgLzoCB65lRId12lRUjXxbx+6lGSLRT44IhKks1Bh1G65INOD5+L6Tg4hEC9KrrrJPkbRAoCFJZXguCMVvj+S17TzkVI8mgLpWZSp6iIAjRWLBhGlChqlUhgk1cT2Z0MeWMOB28mM+pSVaa1SXAB026qZmxd8m4c3JCfLK3DPsUk+Resx75iffaSHbIv2QE7os3hYVj4YOZXzsxtuG+PtkVoaLwSHEUaBZcbla5tRLnD4LGjC+mMpqpeb3aTOpOAhnHbKsJphbm9ZtHT7gkwt6i7wZZNhyKCePnIkHwq8Pr6GV5PEV4uvpW3kFVvxvuSWqwTCk/4cDCZYMqZE3P2Rirwk0n8jDk7vsDT2XAyqXfphDK4M+4WsfBa4rsoGIevL346OIgK/uCdVUZQi4XLqgWLB5R4saISlOyvD7+/WNWgLvfn9ohTGpVMp/Nr6MwKpXziAHSn+kPwTsF92+flzf9hog6fJ+opTtSnAq/nhf0k4RVvIrvYqsjbV8vq83WkU1iufR731j+ORR1svKxAe8OhjXxDpAabGxfYmDMmLBa1eDRam+d///Hxz5+KzqnsXOafsXNB1x/2ugDFPq8iY6eozy7gjr79U5iJQoUW05S73p6QBzwddnuPW/gRQWnutgx0H1W51MfSVTfILb3+jt5xuhA6gXQcO4/oTnJwx9aOg7GWrl6xgs2tg79KZ/1+0uXlP1XPcF8=

@WarmUpTill
Copy link
Owner

Sorry if the answer to the question is obvious, but what types of settings do I need to configure to run into this situation?
I am unable to reproduce the issue since the remux step always finishes too fast. (I guess my development OBS setup might just be too simple)

@DanielLester83
Copy link
Author

My experience is that I stream/record for 2-3+ hours which makes the remux time take longer. Perhaps you could start a recording, unlock and swap the mkv file with a longer test file, then stop the recording. Or maybe the remux option from the "File" pulldown would send the same signal. If all else fails start a recording, wait a couple hours, then click stop.

Perhaps instead it just needs to check if the remux file is open for writing or if it's size has stopped growing.

@DanielLester83
Copy link
Author

To update on this, I was able to find a workaround where a variable is incremented every 250 seconds during a recording, then a macro waits that variables number of seconds befoer preceding. Reduce the number of seconds if your cpu\gpu is slower.

Here's the code for reference:
AAAj0Hic7VpfbyI3EP8qrnUP7TUQluQuElIfUo60SLkcDbn0oaDK7JpdK7vrre1NSCPe+hn6AftJbsb7FwgkaXMpUniIsjsez9+fZwbDHY2Yq6Smnd/uaMwiTjv0Unhckm7A3Su6RxOWaqBOWag5vikWhjwsCTLuBiz2gcOoFN71lUh6M+5+ioeGKVPy+UqmScFkXz4ww2jnjroyDFmiuVfyavEnyDuYz/dKm/qxq3jEY0N6idDS489uWf7mSfdqyI0Rsa/ROsV9oQ1XJUPA9Hka/5gaI+NCNNAGaMwKFTSZVJ+ySc2uQPhBCH+mP+3K2BNGyFhfwI6SQxXyL/gM7KSgr3B3gW51wkoar659zmiw6i4oySzKmRZWT1D54vJ8L4PHsYscpbXDJBQGYjKQ2r5b8CQIorZziEkrn8e5gB6IzoSs3+scvS/3tnBnEfqfpbnit7qWaXAsI8Lucel/nWSk74d8sEyuvLV6V6En4BEUu1J5gACITyh94YJBgIxUMdz6UXpiKhARd9SIiP8OQrVRTMQQMwdwxlGLBc81CzGt5cO7JsgxtwlHD9FukW255krbWDiAeaohB8DRrlTeJ6t1n6zWoizwmLkPunvNlGCTELHCY3zwCgQXK2fZIayOXrHQPiuOJ1glPGLp4YQTzUNuNVP0R11mNiPg4jTK3xz0oMwIHHiMnY+HvO/NaKeBsUwnQ6MgE/mRbdVJtkq0LE74bMAQVSCFNt/SnPaRGTewsoBrKmIPNgIDopsYSZBiWZOQuXxxLSeSG2GCQhzgfyp8TEEWpnrpMeB2ETWZ5CFv2fNjgt4sUVxnWaHfEod8T9rkLTkg35F9cogHWPNuqo2MBkpGSVWaRJykpqDRjLFvaWhcIEOvVpjEygK1Gb0WSsYY1cvFbGJmXB7zYZkqBHQGqL2i7mIJMDxKYO/CsigyZBGEXFZWH3j7scdndaBWMMXzveUgPNqB8PWCcCruA6ClduhPnX07Gen9b3IMNg20STTNdss3dzl5Touya6O/VpvtjKvqMnKH2gGMWJWlwA1uVTodrPu87LhY+8e1Uaoml/yS8vRJo1Qxoe1mqeVZqtJPmOIEzW4+MF8tbbEWN3dD15OHrtbGoesxg9JzDl3rDzwarir3nJbzgg6WVXOTf+13VljZjDv0VyZsjdsovhLa/pcGIvAicBbzX1ih2TU/r6h1IHq10sR1IKsKVJP5zNNvHond6Ps/TB3HIMKPicUT2lgkofP0caTRgChzRbBrNxobh5PPw9754PzTSf+091JzilObUx7bxav+nSVhdxOyuwnZ9qbsPKkrP9C1/ltXTpR0oUTV+/LBC/blQj10otBt8hkCdSrdtMrymgpcHva1BfjJvfAma3FLffDB0K8bF5yvOC6gqRdFga2vbP0Nw+Gu17/eG4ZtAeHumusVg1DZKWoJf3kfqgKfQDSBeUS7ndEIAuMrFpETEXI9Gtm58/T4DJ5Ou6NR3rlG6OeNVFeAmA8CZgcj1W395gzvsZSftSB4sJdmGKE5+eevv6v7s2aUHFK0P+NpNP4wjWkahtpVnMeN7B9ge8LVD206H8839yjnsf3kvg+R23+Ud58dX/FR3hYQ7vrJKwbh1/oio3XfFci4QvDCr1YqgOO94XHxXcheoYG2D2DN41OWhqbEdO1GxYZ27e6uYi72NWICTrrqFnDibpY3NDK5QRQvCW2v7GrVt+WfoB7cMa61Kcq8ydH08D2dfwF3KR7S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants