Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog includes changes that are not in the build #33

Closed
AvdLee opened this issue Mar 5, 2020 · 3 comments · Fixed by #46
Closed

Changelog includes changes that are not in the build #33

AvdLee opened this issue Mar 5, 2020 · 3 comments · Fixed by #46
Assignees
Labels
bug Something isn't working

Comments

@AvdLee
Copy link
Contributor

AvdLee commented Mar 5, 2020

See this release as an example.

We should compare the dates of the tag we're releasing and the previously released tag instead of using the date of today.

Lets see if this is something we can fix within GitBuddy or whether it's something to fix within the Collect app itself.

@AvdLee AvdLee added the bug Something isn't working label Mar 5, 2020
@AvdLee AvdLee self-assigned this Mar 5, 2020
@AvdLee
Copy link
Contributor Author

AvdLee commented Mar 6, 2020

This is caused at this line:

let releasedTag = try tagName.map { try Tag(name: $0, created: Date()) } ?? Tag.latest()

We should not use Date() but the date for the target commitish

@ghost
Copy link

ghost commented Apr 15, 2020

The pull request #46 that closed this issue was merged and released as part of Release 3.0.0 🚀
Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

Generated by GitBuddy

1 similar comment
@ghost
Copy link

ghost commented Apr 15, 2020

The pull request #46 that closed this issue was merged and released as part of Release 3.0.0 🚀
Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant