Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Move file completion responsibility #45

Open
arnoFleming opened this issue Oct 5, 2018 · 0 comments
Open

Move file completion responsibility #45

arnoFleming opened this issue Oct 5, 2018 · 0 comments
Assignees
@arnoFleming
Labels
Ruby SDK v1 All API v2 functionality usable

Comments

@arnoFleming
Copy link
Contributor

arnoFleming commented Oct 5, 2018 •
edited
Loading

Currently, the complete_file! method lives on a WeTransfer::Client instance.

The low level responsibility for signaling that the file is complete should not be on a high object that the client is, but it should be moved to the file (RemoteFile) itself.
@arnoFleming arnoFleming changed the title Ruby SDK: Make completing a file part of the transfer or board, not the client Move file completion responsibility Oct 5, 2018
@arnoFleming arnoFleming added the Ruby SDK v1 All API v2 functionality usable label Oct 8, 2018
@arnoFleming arnoFleming mentioned this issue Oct 26, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arnoFleming arnoFleming

Labels
Ruby SDK v1 All API v2 functionality usable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arnoFleming @davidenko87