Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check aaProvider when sending aaConfig to wallet-service #2031

Merged
merged 2 commits into from
Dec 6, 2024
Merged

check aaProvider when sending aaConfig to wallet-service #2031

merged 2 commits into from
Dec 6, 2024

Conversation

lionellbriones
Copy link
Contributor

@lionellbriones lionellbriones commented Dec 5, 2024 •
edited
Loading

Motivation and Context

Send aaConfig as undefined when there is on accountAbstractionProvider

Jira Link:
https://toruslabs.atlassian.net/browse/PD-4056

Description

How has this been tested?

Screenshots (if appropriate):

Screenshot 2024-12-05 at 12 16 20 PM
Screenshot 2024-12-05 at 12 17 37 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 4:53am

@lionellbriones lionellbriones self-assigned this Dec 5, 2024
tanguyenvn
tanguyenvn approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@tanguyenvn tanguyenvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chaitanyapotti
chaitanyapotti approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 9cb6155 into master Dec 6, 2024
3 of 4 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/send-aa-config-undefined branch December 6, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanguyenvn tanguyenvn tanguyenvn approved these changes

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees

@lionellbriones lionellbriones

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionellbriones @chaitanyapotti @tanguyenvn