Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in spec of relaxeddotmul #158

Open
rossberg opened this issue Sep 3, 2024 · 2 comments
Open

Possible bug in spec of relaxeddotmul #158

rossberg opened this issue Sep 3, 2024 · 2 comments

Comments

@rossberg
Copy link
Member

rossberg commented Sep 3, 2024

The spec defines:

   \EXPROFDET & \relaxeddotmul_{M,N}(i_1, i_2) &=& [ \imul_N(\signed_M(i_1), i_2), \imul_N(\signed_M(i_1), \signed_M(i_2)) ] \\
   & \relaxeddotmul_{M,N}(i_1, i_2) &=& \imul_N(\extends_{M,N}(i_1), \extends_{M,N}(i_2)) \\

The use of signed in the relaxed case seems off. Should that be

   \EXPROFDET & \relaxeddotmul_{M,N}(i_1, i_2) &=& [ \imul_N(\extends_{M,N}(i_1), extendu_{M,N}), \imul_N(\extends_{M,N}(i_1), \extends_{M,N}(i_2)) ] \\

?

@rossberg
Copy link
Member Author

rossberg commented Sep 4, 2024

In fact, aren't the additions missing as well?

@ngzhian
Copy link
Member

ngzhian commented Sep 5, 2024

Ohyea, should be extend to make the bitwidth line up. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants