Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CLOCK_PROCESS_CPUTIME_ID/CLOCK_THREAD_CPUTIME_ID #266

Open
TerrorJack opened this issue Feb 15, 2022 · 2 comments
Open

Remove CLOCK_PROCESS_CPUTIME_ID/CLOCK_THREAD_CPUTIME_ID #266

TerrorJack opened this issue Feb 15, 2022 · 2 comments

Comments

@TerrorJack
Copy link
Contributor

After WebAssembly/WASI#197 has landed, CLOCK_PROCESS_CPUTIME_ID/CLOCK_THREAD_CPUTIME_ID are invalid in recent versions of wasmtime/uvwasi, even if targetting wasi snapshot 1. This leads to runtime error, so I propose we do something about it:

  • Remove these two from wasi-libc altogether
  • Alias to CLOCK_MONOTONIC to make it sort of work
@sunfishcode
Copy link
Member

I agree. Aliasing the process-oriented clock IDs to CLOCK_MONOTONIC would make sense to do under the _WASI_EMULATED_PROCESS_CLOCKS flag, which is already emulating some of the process-oriented clock features in terms of CLOCK_MONOTONIC.

@amesgen amesgen mentioned this issue Apr 30, 2023
Merged
mhdawson added a commit to mhdawson/io.js that referenced this issue Oct 3, 2023
@mhdawson
wasi: fix up wasi tests for ibmi
44a5528 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be needed
    with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
mhdawson added a commit to mhdawson/io.js that referenced this issue Oct 3, 2023
@mhdawson
wasi: fix up wasi tests for ibmi
7873db3 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be needed
    with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
mhdawson added a commit to mhdawson/io.js that referenced this issue Oct 3, 2023
@mhdawson
wasi: fix up wasi tests for ibmi
d7650a3 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Oct 4, 2023
@mhdawson
wasi: fix up wasi tests for ibmi
9cb8eb7 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #49953
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@mhdawson @alexfernandez
wasi: fix up wasi tests for ibmi
b6d4f54 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#49953
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Nov 11, 2023
@mhdawson @targos
wasi: fix up wasi tests for ibmi
5b695d6 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #49953
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@encukou encukou mentioned this issue Feb 20, 2024
Closed
@brettcannon
Copy link

Can this be removed now? python/cpython#115714 stumbled across this causing incorrect results.

@encukou encukou mentioned this issue Feb 21, 2024
Merged
debadree25 pushed a commit to debadree25/node that referenced this issue Apr 15, 2024
@mhdawson @debadree25
wasi: fix up wasi tests for ibmi
0475027 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#49953
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @TerrorJack @sunfishcode