Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pin exact keripy version in setup.py #242

Merged

Conversation

iFergal
Copy link
Collaborator

@iFergal iFergal commented May 14, 2024

To close #163 - >= is pulling 1.2.0-dev2 for me in a fresh build which is breaking. In absence of a lockfile, == brings better determinism in our builds.

@pfeairheller
Copy link
Member

Looks like you at least need dev1

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (caad67b) to head (b450477).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   92.82%   92.83%   +0.01%     
==========================================
  Files          37       37              
  Lines        6982     6995      +13     
==========================================
+ Hits         6481     6494      +13     
  Misses        501      501              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iFergal
Copy link
Collaborator Author

iFergal commented May 14, 2024

Yeah, 0.2.0-dev0 tag required dev0 which is where I saw the issue originally, forgot main would be different.

Has passed now with dev2 which is what the last PR build on main used so I just matched that.

@pfeairheller pfeairheller merged commit 5bdc473 into WebOfTrust:main May 14, 2024
5 checks passed
@iFergal iFergal deleted the build/pinKeripyVersion branch May 14, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locking keripy dependency
2 participants