Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle supporting files appropriately #40

Closed
jandrieu opened this issue Apr 29, 2019 · 5 comments
Closed

Bundle supporting files appropriately #40

jandrieu opened this issue Apr 29, 2019 · 5 comments
Labels
MVP

Comments

@jandrieu
Copy link
Contributor

We currently have a bug because the default.md isn't bundled. Other assets need to come along too.
@jandrieu jandrieu added the MVP label Apr 29, 2019
@wip-abramson
Copy link
Member

Okay so this now works I think, needs testing on other OS

@wip-abramson
Copy link
Member

Actually, its a bit weird on linux. We can review next Monday

1 similar comment
@wip-abramson
Copy link
Member

Actually, its a bit weird on linux. We can review next Monday

@jandrieu
Copy link
Contributor Author

I added an issue at Electron-Builder
electron-userland/electron-builder#3889

It appears that the icon path is not being quoted, leading to problems on Windows. For now, you may need to comment out the icon spec to get it to build a release.

@wip-abramson
Copy link
Member

I have added a mac build config - someone to test.

When I build for linux I don't see the logo either.

@wip-abramson wip-abramson mentioned this issue Jun 24, 2019
Closed
@ghost ghost mentioned this issue Aug 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MVP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jandrieu @wip-abramson