Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json to upgrade nesbot/carbon to V3 #537

Open
phpfui opened this issue Dec 9, 2024 · 5 comments
Open

Update composer.json to upgrade nesbot/carbon to V3 #537

phpfui opened this issue Dec 9, 2024 · 5 comments

Comments

@phpfui
Copy link

phpfui commented Dec 9, 2024

Happy to submit a PR for this, but I want to make sure it will be accepted first and that the project is still maintained.

Also it appears that #518 will fix PHP 8.4 nullable parameter depreciation. I would like that as well.

@larsbo
Copy link

larsbo commented Dec 17, 2024

A PR is not needed, the composer.json has already been updated 8 months ago: 8696b28
But the release for this change is still missing.
@Webklex can you publish the change as a new release, please?

@it-can
Copy link

it-can commented Dec 23, 2024

@Webklex can you release a new tag?

@mrhewitt
Copy link

mrhewitt commented Jan 8, 2025

Just in case it helps anybody, it appears this (upgrade nesbot/carbon to V3) may also fix issues you may encounter using this library with Symfony 7.1

Tagged version 5.5 using old Carbon seemed to required symfony/translate for version 6, and refused to work in my 7.1 application, switching from 5.5 to dev-master "fixed" this (I know its not a solution really to use master branch and not a release, but just adding this in case anyone else battles with Symfony 7)

I do hope this is not abandoned, not sure how many others like myself are here because of PHP imap module being removed and depreciated from 8.4, would not bode well it this project was dead as well.

@phpfui
Copy link
Author

phpfui commented Jan 8, 2025

I actually switched to javanile/php-imap2 which is more of a drop in replacement for the imap_ functions (just make them imap2_), but don't have it working just yet with my code, as I have not had enough time to debug it. Still trying to get other packages to support 8.4.

But yes, I think this PR should work and be approved. Shame to see a good package abandoned due to inactivity of the maintainer.

@larsbo
Copy link

larsbo commented Jan 8, 2025

Yes, maybe he can add more maintainer to the project to assist with updates.

@Webklex what do you think? I would like to help out. PS: I even live nearby you 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants